-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovirt_cluster: Fix cluster cpu arch comparision #34446
Merged
ansibot
merged 1 commit into
ansible:devel
from
machacekondra:ovirt_cluster_cpu_arch_compare_fix
Jan 4, 2018
Merged
ovirt_cluster: Fix cluster cpu arch comparision #34446
ansibot
merged 1 commit into
ansible:devel
from
machacekondra:ovirt_cluster_cpu_arch_compare_fix
Jan 4, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c564b77
to
831a3a1
Compare
shipit |
mwperina
approved these changes
Jan 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
gerrit-ovirt-org
pushed a commit
to oVirt/ovirt-hosted-engine-setup
that referenced
this pull request
Feb 28, 2018
Enable gluster at cluster level on HC deployments before adding the first host. Backport ovirt_cluster.py from ansible 2.5 to fix an issue ( ansible/ansible#34446 ) still affecting ansible 2.5. Change-Id: I93b7da8915a90306ed4b4807c42435321dcbe4f6 Bug-Url: https://bugzilla.redhat.com/1543486 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
gerrit-ovirt-org
pushed a commit
to oVirt/ovirt-hosted-engine-setup
that referenced
this pull request
Feb 28, 2018
Enable gluster at cluster level on HC deployments before adding the first host. Backport ovirt_cluster.py from ansible 2.5 to fix an issue ( ansible/ansible#34446 ) still affecting ansible 2.5. Change-Id: I93b7da8915a90306ed4b4807c42435321dcbe4f6 Bug-Url: https://bugzilla.redhat.com/1543486 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> (cherry picked from commit 2a66808)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.5
This issue/PR affects Ansible v2.5
automerge
This PR was automatically merged by ansibot.
bug
This issue/PR relates to a bug.
cloud
module
This issue/PR relates to a module.
ovirt
oVirt and RHV community
owner_pr
This PR is made by the module's maintainer.
shipit
This PR is ready to be merged by Core
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
oVirt REST API don't return cpu/arch elelemnt in case it's not set, so we fail the update check. We can just ignore that comparsion in case it's not set, so it's resolve the issue.
ISSUE TYPE
COMPONENT NAME
ovirt_cluster
ANSIBLE VERSION
ADDITIONAL INFORMATION